Transfer biophysical variables for output with FATES dimensions#3760
Open
glemieux wants to merge 7 commits intoESCOMP:masterfrom
Open
Transfer biophysical variables for output with FATES dimensions#3760glemieux wants to merge 7 commits intoESCOMP:masterfrom
glemieux wants to merge 7 commits intoESCOMP:masterfrom
Conversation
5 tasks
github-project-automation
bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
5 tasks
Collaborator
Author
|
Fates regression testing of NGEET/fates#1536 is complete and B4B. Aside from updating the Changelog and the fates tag and commit, this is good to review. |
rgknox
reviewed
Feb 24, 2026
glemieux
moved this from Finding Reviewers
to Under Review
in FATES Pull Request Planning and Status
Change to using the ifx compiler and some more fixes Updates ccs_config to 1.0.75 which has the new ifx compiler in use for derecho_intel, as well as updating to using ESMF8.9.0. This exposed problems in the code on two fronts when running with DEBUG mode: Reliance on short-circuiting in if statements Problems with NaN's, in datasets especially _FillValue For the former, we changed code to break up if statements so this would work. And with the latter we point to new datasets with the NaN's handled. mosart and cdeps code also had short-circuiting problems. @samsrabin created a script to examine all of the files in namelist_defaults_ctsm.xml and in the testmod directories to check if there were problems with NaN's in _FillValues. The modified files here all were the result of the first pass of that script. The new files all have a ".no_nan_fill.nc" ending on them. Includes updating submodules: ccs_config, cdeps, mosart
Collaborator
Author
|
Regression testing This might be related to #3797: This might be related to #3617: Note that I was seeing an issue with Results: |
Collaborator
Author
Resubmitting cleared this particular unexpected failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This pull request updates the high frequency wrapper procedure in the interface to pass biophysical CLM variables to be output along FATES dimensions. The FATES land use x pft dimension is also added to the history module.
This pull request integration needs to be coordinated with NGEET/fates#1536.
Specific notes
Contributors other than yourself, if any: @ckoven
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)?
Any User Interface Changes (namelist or namelist defaults changes)?
Does this create a need to change or add documentation? Did you do so?
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).